Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: early play should wait for player ready, even if source is available #4134

Merged
merged 2 commits into from
Mar 2, 2017
Merged

fix: early play should wait for player ready, even if source is available #4134

merged 2 commits into from
Mar 2, 2017

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 24, 2017

Fixes #4057

brandonocasey
brandonocasey reviewed Feb 27, 2017
View reviewed changes
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm interesting This LGTM, I am just wondering if there is any way to add a unit test for this

@gkatsev
Copy link
Member Author

gkatsev commented Feb 27, 2017

I can take a look at adding a unit test for this. We probably can do it. I'll look into it after I finish fixing the current player.test.js tests.

misteroneill
misteroneill approved these changes Feb 27, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A test would be nice.

@Isabela96
Copy link

Looks great

@gkatsev
Copy link
Member Author

gkatsev commented Feb 28, 2017

Should be rebased against master, should make tests run better.

@gkatsev gkatsev merged commit 3bbf019 into master Mar 2, 2017
@gkatsev gkatsev deleted the playball branch March 2, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey left review comments

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkatsev @Isabela96 @misteroneill @brandonocasey